Update test case related to LEACY datetime format to unblock nightly CI #11544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chong Gao <[email protected]>
|
build |
|
Do we need to update the 24.10 branch? @pxLi |
yes, this is blocking 24.10 interminttently |
res-life
changed the title
|
can you retarget to 24.10? thanks |
This PR is fixing 24.10. |
|
build |
added 3 commits
October 8, 2024 10:06
|
build |
|
Updated, only test years after 1900. |
firestarman
previously approved these changes
Oct 8, 2024
|
Will confilct with branch-24.10: #11567 |
|
build |
revans2
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11539
Changes
Update test case: Only test years after 1900
Description
This issue is related to LEGACY mode, Spark itself has different behaviors between LEGACY mode and non-LEGACY mode, and Rapids kernel has not 100% matched non-LEGACY yet.
Rapids keeps consistent with Spark when mode is CORRECTED mode.
We already documented that
LEGACYmode has several limitationsSo only update test case.
Signed-off-by: Chong Gao [email protected]